Skip to content

[DependencyInjection] [LazyServices] Add #[Autoconfigure] attribute mention #17784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexandre-daubois
Copy link
Member

While watching @nicolas-grekas' SymfonyCon talk about lazy objects to give a try to #16970, he told that the documentation about #[Autoconfigure(lazy: ...)] was missing. So here it is 😄

@carsonbot carsonbot added this to the 5.4 milestone Jan 21, 2023
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Can you also please remove all occurrences of ProxyManager from the doc v6.2? It's not needed anymore.

@alexandre-daubois
Copy link
Member Author

alexandre-daubois commented Jan 21, 2023

Of course! I'll take care of this within the PR about the 2 traits 👍

@carsonbot carsonbot changed the title [LazyServices] Add #[Autoconfigure] attribute mention [DependencyInjection] [LazyServices] Add #[Autoconfigure] attribute mention Jan 23, 2023
@javiereguiluz javiereguiluz merged commit 0aa2d60 into symfony:5.4 Jan 23, 2023
@javiereguiluz
Copy link
Member

Thanks!

@alexandre-daubois alexandre-daubois deleted the autoconfigure-attribute-laziness branch January 23, 2023 11:30
javiereguiluz added a commit that referenced this pull request Jun 8, 2023
…documentation (alexandre-daubois)

This PR was merged into the 6.2 branch.

Discussion
----------

[VarExporter] Add `LazyGhostTrait` and `LazyProxyTrait` documentation

Friendly ping `@nicolas`-grekas for your review on this technical one. I based myself a lot on the README of VarExporter that was filled-in (thanks for this, that was some priceless help here!) and your SymfonyCon talk.

About your comment #17784 (review), it seems that occurrences of ProxyManager have already been removed for 6.2 and above. 🙂

Fixes #16970
Fixes #17249

Commits
-------

ae0f85f [VarExporter] Add `LazyGhostTrait` and `LazyProxyTrait` documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants