Skip to content

Fix setParameter for RouteCollection in Create Framework tutorial #20928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

Fix setParameter for RouteCollection in Create Framework tutorial #20928

merged 1 commit into from
May 5, 2025

Conversation

alamirault
Copy link
Contributor

@alamirault alamirault commented May 1, 2025 •
edited
Loading

Try fix #20823

$routes is a RouteCollection instance, so it cannot be a container parameter.

I replaced it by a reference and set. I don't know if it's the best way, or if the section is really needed

@carsonbot carsonbot added this to the 7.3 milestone May 1, 2025
@alamirault alamirault changed the base branch from 7.3 to 6.4 May 1, 2025 11:51
@javiereguiluz javiereguiluz modified the milestones: 7.3, 6.4 May 5, 2025
@javiereguiluz
Copy link
Member

Thanks!

@javiereguiluz javiereguiluz merged commit bc4cdb6 into symfony:6.4 May 5, 2025
3 checks passed
@alamirault alamirault deleted the hotfix/20823-2 branch May 5, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

Incorrect Usage of setParameter for RouterCollection in "Create Framework" Tutorial
4 participants
@alamirault @javiereguiluz @xabbuh @carsonbot