[Console] Document invokable command

[yceruto]

Closes #20553

• Make invokable commands first-class citizen
• Move old command definition to a separate section

Pending docs to be updated:

• components/console/console_arguments.rst (full refactoring required)
• components/console/helpers/questionhelper.rst (full refactoring required)
• console/input.rst (full refactoring required)
• console.rst (full refactoring required)

[alamirault]

I like the harmonization of some command names 👍

[OskarStark]

maybe we should make all these changes with the #AsCommand attribute in a separate PR to avoid growing this PR?

[yceruto]

I’d actually prefer to keep all these related changes in a single PR, since they’re closely tied together. It helps keep the context in one place and makes it easier to review everything as a whole.

In any case, we can go ahead and merge this one, then open a new PR for the remaining updates.

[yceruto]

Thanks @alamirault and @OskarStark for your review 🙏

I’m actively looking for someone to help me refactor console.rst, as I’m running out of free-time before the final release.

[94noni]

this wont work isnt it ?
or are those console helper injectable in some ways ?

[yceruto]

Good catch! Yes, there is a way, but I’m not sure if it’s simpler to extend Command or to get the helper via:

public function __invoke(InputInterface $input, OutputInterface $output, Application $application): int
{
    $helper = $application->getHelperSet()->get('question');

    // ...
}

Anyway, this all looks old-fashioned, because SymfonyStyle can do it better. There’s even a note right at the beginning:

.. note::

    As an alternative, consider using the
    :ref:`SymfonyStyle <symfony-style-questions>` to ask questions.

IMO, it’s not just an alternative, but the simplest way to ask questions from now on:

public function __invoke(SymfonyStyle $io): int
{
    $answer = $io->ask(...);
}

[yceruto]

I think we should do the same here as with invokable commands: start with the simpler approach (SymfonyStyle), then mention alternatives for custom needs. wdyt @symfony/docs ?

[94noni]

for documentation I agree yes, basic usage then more advance 👍🏻

a question just: cant we imagine those helper as console service as injectable in the invoke method ? (can open an dedicated issue for later :))

[94noni]

Pending docs to be updated:

I would also add https://symfony.com/doc/current/console/input.html, wdyt @yceruto ?
I can help on this in a separate unitary PR if its ok

[yceruto]

Thanks, Antoine! Sure, go for it.

Here we're discussing input related topics symfony/symfony#59602