Skip to content

[HttpFoundation] Fix links to ParameterBag methods #2245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2013

Conversation

michaelperrin
Copy link
Contributor

Links pointed to (non-existing) Request class methods instead of ParameterBag ones.

weaverryan added a commit that referenced this pull request Feb 19, 2013
[HttpFoundation] Fix links to ParameterBag methods
@weaverryan weaverryan merged commit 376f06e into symfony:2.0 Feb 19, 2013
@weaverryan
Copy link
Member

Hi Michaël! Nice fix and PR - thanks!

@michaelperrin
Copy link
Contributor Author

Hi Ryan, thanks for the merge!

However I noticed that on the Symfony website, all links to API methods don't point to the correct anchor name. The fix is easy: just update the Sphinx Extensions for PHP and Symfony on the build server, which will include one of your recent commits!

I opened an issue for this: #2254 @weaverryan

@michaelperrin michaelperrin deleted the fix/parameter-bag-links-2.0 branch February 19, 2013 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants