document DateType limitations #2403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please use the pull request format? And could you also read the rest of that overview document? You're missing some formatting things (and the document doesn't follow the standards) |
|
Oops, sure thing. Thanks for the quick feedback. |
|
I added the pull request format to my original comment and broke the lines under 80 characters. I didn't see any other violations. If I missed something, please let me know. |
| this format. | ||
|
|
||
| Note: If ``timestamp`` is used, ``DateType`` is limited to dates between |
There was a problem hiding this comment.
it should be:
.. note::
If ``timestamp`` is used, ...And maybe change the .. note:: block to a .. caution:: block
|
👍 |
1 similar comment
|
👍 |
weaverryan
added a commit
that referenced
this pull request
Mar 31, 2013
document DateType limitations
|
Top notch Joel - merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to Issue 2266. I wasn't sure if it made sense to consolidate this into one note, since the two options are so close, but I kept them separate for now. Feedback welcome.