Skip to content

Document spool type #2742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Document spool type #2742

wants to merge 1 commit into from

Conversation

tvlooy
Copy link
Contributor

@tvlooy tvlooy commented Jun 19, 2013

This is a known thing (https://github.com/symfony/symfony-standard/issues/425) but not documented. I think many people will trip over this, so I'm suggesting adding a tip about it.

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets

@@ -95,6 +95,12 @@ setting means that the output is then passed onto the ``buffered`` handler.

.. tip::

When the application crashes with an error 5xx, the swiftmailer memory spool
will not be flushed and no mails will be sent. You need to comment out the the
``spool: { type: memory }`` in your config.yml so the mails will be sent immediately.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filename should be in a literal too

@wouterj
Copy link
Member

wouterj commented Jun 19, 2013

@weaverryan it should be merged in the 2.2 branch

@weaverryan
Copy link
Member

I think this is a good note to add. BUT, I'm not sure if the note is correct yet:

  1. My impression from looking at symfony/symfony-standard#425 is that this has nothing to do with 500 errors. My understanding is that if my application spools emails in memory, and then an Exception is thrown, the terminate event would still be triggered and the spooled emails sent. What this issue seems to be is simply that if monolog has spooled any mails (which in production, it usually only logs 500 level things), those will not be sent. Is this correct? If so, I think we should change the message - it sounds like a 500-level error will prevent my application emails to not send either.

  2. The "You need to comment out the ... so the mails will be sent immediately" gave me the impression (which I know you don't intend) that the if my application fails to send some memory-spooled emails, that after I change this configuration, it will immediately "catch-up" and send all the emails that were previously-not sent. I know that's not what you're trying to say, so perhaps we can reword this as well :).

Thanks for taking this on - obviously a lot of people are coming across this issue, so I would like to cover it in the docs.

Cheers!

@weaverryan
Copy link
Member

Hi Tom!

This issue is now closed in #2830.

Thanks!

@weaverryan weaverryan closed this Jul 20, 2013
@tvlooy
Copy link
Contributor Author

tvlooy commented Jul 21, 2013

Ah. Totally forgot about this one. Glad someone else fixed it! Thanks.

@tvlooy tvlooy deleted the mail_tip branch December 15, 2013 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants