[WIP] ePub generation fixes #7347
Conversation
index.rst
Outdated
| .. toctree:: | ||
| :hidden: | ||
|
|
||
| changelog |
There was a problem hiding this comment.
Looks like you have to keep this (see the failing build on Travis CI).
There was a problem hiding this comment.
This was intentional as the generated file contains the whole changelog, which is huge and not really useful. But I'm going to remove it for now, and we can decide later if it is relevant to keep it.
* Add missing `</div>` closing tag. * Add missing quotes for attributes. * Add missing `</body>` closing tag. These syntax errors were causing errors in Apple iBooks when opening generated ePub files.
michaelperrin
force-pushed
the
epub-generation
branch
from
01be426 to
b64bf0d
Compare
|
@xabbuh I removed the changelog removal (!) for now. |
|
Would love to see this merged. Big thanks, @michaelperrin. |
|
Thanks @sepehr . The generated ePub file could be better, but this PR can't do any harm anyway as it basically fixes HTML issues is the docs (missing closing tags, missing quotes for HTML attributes, etc.). |
|
Yeah, even with these fixes, there are a lot of problems with the generated epub. @michaelperrin, Is there any chance that you have working compiled epub of Symfony 3.x docs? If so, I'd be grateful if you share it. |
|
@sepehr I didn't know the |
I don’t see the reason why double `<body>` tags were needed. I am removing them for now.
Useful for ePub generation, that makes use of XHTML files.
|
@michaelperrin I'm sorry we didn't merge this on time. If you could rebase it, I'd merge it quickly. I guess there will be still some issues in the generated ePub, but as you said, there are too many to fix them all. the work you did here is good enough to fix some things. Thank you. |
|
Let's close this one because we have problems even to generate HTML and PDF ... so we can't dedicate resources to a new format. I'm sorry. |
|
@javiereguiluz Yep, better closing it indeed. |
This PR enables back the generation of ePub files. It fixes #5707 and #6485.
The main problems were due to:
Note that I didn't change the strange need of a double
<body>tag (yup, that's really strange, but there must be a reason).Generating the ePub file can be done with the following command:
I have tested the generated file in Apple iBooks, and it works fine.
I also removed the changelog from the generated file, as it was making a really big file without any added value. I can put it back if you wish.
EDIT: I put it back for now
I can also squash the commits into one.