Skip to content

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues -
License MIT

This change is required to make our CI green on branches that didn't migrate out of the phpunit-bridge, which means 6.4 and 7.3.

By the time PHP 8.5 will be really adopted, ppl will have moved away from Symfony 6.4/7.3 anyway (or will need to deal with the deprecations on their own).

I already wrote a lot about ways to fix this deprecation, and it's not trivial, so that ignoring is the best course of action.

As a reminder, branch 7.4 moved away from those magic methods already.

@carsonbot carsonbot added this to the 6.4 milestone Sep 11, 2025
@nicolas-grekas nicolas-grekas merged commit 85b7f4a into symfony:6.4 Sep 11, 2025
7 of 12 checks passed
@nicolas-grekas nicolas-grekas deleted the pb-silent-sleep branch September 11, 2025 11:49
@stof
Copy link
Member

stof commented Sep 11, 2025

Wouldn't this silence deprecations coming from other packages than Symfony as well, making it harder to discover that they are not ready to migrate ?

@nicolas-grekas
Copy link
Member Author

It would yes. We can tweak this once https://wiki.php.net/rfc/soft-deprecate-sleep-wakeup is settled.
I don't think that's an issue thought: by the time, ppl would have moved away from the bridge by upgrading to phpunit 12.

This was referenced Sep 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants