feat(live): improve TestLiveComponent::actingAs()
#1461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kbond Using your changes works in my case. I no longer get the CSRF-exception. |
kbond
force-pushed
the
feat/live-improve-test-helper
branch
2 times, most recently
from
aa732fc to
0546030
Compare
|
Rebased and fixed the failing test I introduced in #1460. |
kbond
force-pushed
the
feat/live-improve-test-helper
branch
from
0546030 to
f9d27c6
Compare
weaverryan
force-pushed
the
feat/live-improve-test-helper
branch
from
f9d27c6 to
d0a4713
Compare
|
Thanks Kevin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(depends on #1460)
Currently, if you have a component that requires authentication for all actions (ie
#[IsGranted]on the component class), in your tests, as soon as you call$this->createLiveComponent(...), you'll get an access denied exception. You never get a chance to call->actingAs().This PR makes the initial request for the live component lazy. Only when the initial request is required (for other methods), is it made. This gives you the chance to call
->actingAs()before the initial render.