[Turbo] Fixing support for not using old ClassUtils #1471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
weaverryan
commented
Feb 7, 2024
weaverryan
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| Issues | Fix #1469 |
| License | MIT |
weaverryan
force-pushed
the
turbo-doctrine-class-utils-support
branch
from
79cb86c to
536f8b1
Compare
weaverryan
force-pushed
the
turbo-doctrine-class-utils-support
branch
from
536f8b1 to
4753fc3
Compare
|
This, indeed, fixes the reported problem |
stloyd
reviewed
Feb 8, 2024
| } | ||
|
|
||
| // @legacy for old versions of Doctrine | ||
| if (class_exists(ClassUtils::class)) { |
There was a problem hiding this comment.
This class is not imported so it will always return false.
1 task
| if ($entity instanceof LazyObjectInterface) { | ||
| $entityClass = get_parent_class($entity); | ||
| if (false === $entityClass) { | ||
| throw new \LogicException('Parent class missing'); |
There was a problem hiding this comment.
no need for this exception IMHO, using get_class should be the way if there's no parent
| public static function getEntityClass(object $entity): string | ||
| { | ||
| if ($entity instanceof LazyObjectInterface) { | ||
| $entityClass = get_parent_class($entity); |
There was a problem hiding this comment.
return get_parent_class($entity) ?: \get_class($entity);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.