[TwigComponent] Twig "use_yield" compatibility #1487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
added a commit
that referenced
this pull request
Feb 14, 2024
…rue` for now) (smnandre) This PR was squashed before being merged into the 2.x branch. Discussion ---------- [Twig][Live] Skip Twig 3.9 🚒 (do not set `use_yield = true` for now) As Symfony Twig Bridge & Twig Bundle have decided to skip Twig 3.9 for now, we should do the same, as testing and/or maintaining a compatible version would be really hard without the bundle support. symfony/twig-bridge@2abddb1 symfony/twig-bundle@23a02ff Update: Twig 3.9 introduce a major change in the way templates are rendered, and to fully test/fix our compatibility, we need to wait Bridge and Bundle to allow Twig 3.9 In the meantime, please do not set "use_yield = true" as we are not ready yet. This is something that has a major impact on TwigComponent and LiveComponent, and we'll probably need some changes on the CI / test suite to handle both modes. --- Pull Request (compatibility - wip) : #1487 (help welcomed) Issue: #1390 Twig PR : twigphp/Twig#3950 Commits ------- 6165384 [Twig][Live] Skip Twig 3.9 🚒 (do not set `use_yield = true` for now)
symfony-splitter
pushed a commit
to symfony/ux-live-component
that referenced
this pull request
Feb 14, 2024
…rue` for now) (smnandre) This PR was squashed before being merged into the 2.x branch. Discussion ---------- [Twig][Live] Skip Twig 3.9 🚒 (do not set `use_yield = true` for now) As Symfony Twig Bridge & Twig Bundle have decided to skip Twig 3.9 for now, we should do the same, as testing and/or maintaining a compatible version would be really hard without the bundle support. symfony/twig-bridge@2abddb1 symfony/twig-bundle@23a02ff Update: Twig 3.9 introduce a major change in the way templates are rendered, and to fully test/fix our compatibility, we need to wait Bridge and Bundle to allow Twig 3.9 In the meantime, please do not set "use_yield = true" as we are not ready yet. This is something that has a major impact on TwigComponent and LiveComponent, and we'll probably need some changes on the CI / test suite to handle both modes. --- Pull Request (compatibility - wip) : symfony/ux#1487 (help welcomed) Issue: symfony/ux#1390 Twig PR : twigphp/Twig#3950 Commits ------- 61653842 [Twig][Live] Skip Twig 3.9 🚒 (do not set `use_yield = true` for now)
smnandre
force-pushed
the
sa/yield-template
branch
4 times, most recently
from
c8974e3 to
7ecfb65
Compare
smnandre
changed the title
kbond
approved these changes
Apr 19, 2024
carsonbot
added
Status: Reviewed
kbond
force-pushed
the
sa/yield-template
branch
from
08c6f57 to
b07d799
Compare
|
Thanks Simon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use YielReady and allow Twig 3.9
Need #1753 to be merged first