[Live] Fixing bug where the active input would maintain its value, but lose its cursor position #1501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smnandre
reviewed
Feb 15, 2024
| @@ -27,7 +27,7 @@ | |||
| } | |||
| }, | |||
| "dependencies": { | |||
| "idiomorph": "^0.3.0" | |||
| "idiomorph": "https://github.com/bigskysoftware/idiomorph.git" | |||
There was a problem hiding this comment.
Yup, but good question. Copied from Turbo - it allows us to get the absolute latest version. Will change after they tag next. We embed this library (for now), so this isn't exposed to the user.
smnandre
reviewed
Feb 15, 2024
| // a special case: replacing the value isn't enough. We need to | ||
| // prevent the value from being changed in the first place so the | ||
| // user's cursor position is maintained. | ||
| ignoreActiveValue: true, |
|
Checked on the demos: 👍 |
…t lose its cursor position
weaverryan
force-pushed
the
live-fix-active-input-cursor
branch
from
137b5d5 to
d3d475a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only affects "model" elements, as unmapped element changes are tracked and the "to" element's value updated in the beforeNodeMorphed() callback.
Also, this setting matches Turbo 8. This also updates Idiomorph to the absolute latest version, which includes a related bug fix.
Cheers!