Skip to content

[LiveComponent] Throw exception for typed LiveProps as interfaces #1593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2024
Merged

[LiveComponent] Throw exception for typed LiveProps as interfaces #1593

merged 1 commit into from
Mar 20, 2024

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented Mar 8, 2024

Q A
Bug fix? yes
New feature? no
Issues Fix #1590
License MIT

Check is done just after the hydration extensions are called, to allow userland implementations.

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Mar 8, 2024
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Mar 9, 2024
@kbond
Copy link
Member

kbond commented Mar 20, 2024

Thanks Simon.

@kbond kbond merged commit 500d3f9 into symfony:2.x Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WebMamba WebMamba WebMamba approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[LiveComponent] LiveComponentHydrator doesn't handle interfaces
4 participants
@smnandre @kbond @WebMamba @carsonbot