Skip to content

[Icon] Console theme: reference the webite + improve icon readability #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

smnandre
Copy link
Member

Currently:
Capture d’écran 2024-03-10 à 05 04 02

I'd suggest one of those... Open to debate :)

Capture d’écran 2024-03-10 à 05 27 26 Capture d’écran 2024-03-10 à 05 26 32

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Mar 10, 2024
@kbond
Copy link
Member

kbond commented Mar 10, 2024

Love it, I like the second example.

@smnandre
Copy link
Member Author

smnandre commented Mar 10, 2024

Done :)

(if you have a slow connection or if anything happen, the first line (// Importing.... ) is displayed during the download, and then replaced when the icon is downloaded)

@kbond
Copy link
Member

kbond commented Mar 11, 2024

Can you fix the failing test?

@smnandre
Copy link
Member Author

smnandre commented Mar 11, 2024

Done!

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Mar 11, 2024
@kbond kbond force-pushed the ux-icons-command branch from f25d857 to 3d7b0b5 Compare March 11, 2024 01:42
@kbond
Copy link
Member

kbond commented Mar 11, 2024

Thanks Simon.

@kbond kbond merged commit 29be872 into symfony:2.x Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants