Skip to content

[Autocomplete] Command make:autocomplete-field output a doc compliant class #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Autocomplete/src/Maker/MakeAutocompleteField.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
use Symfony\Component\Form\FormInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;
use Symfony\UX\Autocomplete\Form\AsEntityAutocompleteField;
use Symfony\UX\Autocomplete\Form\ParentEntityAutocompleteType;
use Symfony\UX\Autocomplete\Form\BaseEntityAutocompleteType;

/**
* @author Ryan Weaver <[email protected]>
Expand Down Expand Up @@ -121,7 +121,7 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
AbstractType::class,
OptionsResolver::class,
AsEntityAutocompleteField::class,
ParentEntityAutocompleteType::class,
BaseEntityAutocompleteType::class,
]);

$variables = new MakerAutocompleteVariables(
Expand Down
20 changes: 9 additions & 11 deletions src/Autocomplete/src/Maker/skeletons/AutocompleteField.tpl.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<?php

use Symfony\Bundle\MakerBundle\Str;
use Symfony\UX\Autocomplete\Maker\MakerAutocompleteVariables;

/** @var MakerAutocompleteVariables $variables */
Expand All @@ -16,24 +15,23 @@
#[AsEntityAutocompleteField]
class <?php echo $class_name; ?> extends AbstractType
{
public function configureOptions(OptionsResolver $resolver)
public function configureOptions(OptionsResolver $resolver): void
{
$resolver->setDefaults([
'class' => <?php echo $variables->entityClassDetails->getShortName(); ?>::class,
'placeholder' => 'Choose a <?php echo $variables->entityClassDetails->getShortName(); ?>',
//'choice_label' => 'name',

<?php if ($variables->repositoryClassDetails) { ?>
'query_builder' => function(<?php echo $variables->repositoryClassDetails->getShortName(); ?> $<?php echo Str::asLowerCamelCase($variables->repositoryClassDetails->getShortName()); ?>) {
return $<?php echo Str::asLowerCamelCase($variables->repositoryClassDetails->getShortName()); ?>->createQueryBuilder('<?php echo Str::asLowerCamelCase($variables->entityClassDetails->getShortName()); ?>');
},
<?php } ?>
//'security' => 'ROLE_SOMETHING',
// 'choice_label' => 'name',

// choose which fields to use in the search
// if not passed, *all* fields are used
// 'searchable_fields' => ['name'],

// 'security' => 'ROLE_SOMETHING',
]);
}

public function getParent(): string
{
return ParentEntityAutocompleteType::class;
return BaseEntityAutocompleteType::class;
}
}
Loading