Skip to content

[Site] Refactor Translator page #1783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented Apr 25, 2024

  • remove highlight
  • remove big JS controller
  • add block controller
  • fix some minor spacing issues
  • display both locales at once

translator-bis

@carsonbot carsonbot added Site ux.symfony.com Status: Needs Review Needs to be reviewed labels Apr 25, 2024
@Kocal
Copy link
Member

Kocal commented Apr 25, 2024

Nice one :)

@smnandre
Copy link
Member Author

Nice one :)

It's only because I really, really want to switch to tempest/highlight soon :))

@javiereguiluz
Copy link
Member

Very nice! Thanks!

A minor question ... in the screenshot, why does it say 5,700% of the work is done when passing 0.5? It should say 50% of the work is done, right?

@smnandre
Copy link
Member Author

Very nice! Thanks!

A minor question ... in the screenshot, why does it say 5,700% of the work is done when passing 0.5? It should say 50% of the work is done, right?

I’ve not finished 😅

@smnandre smnandre force-pushed the site/refacto-translator-page branch from f5fa7a3 to bf6f050 Compare April 27, 2024 22:35
@smnandre
Copy link
Member Author

Good for me

translator-2

@smnandre smnandre requested review from kbond and javiereguiluz April 27, 2024 23:14
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Apr 30, 2024
@kbond kbond force-pushed the site/refacto-translator-page branch from 648d21a to 97266a5 Compare April 30, 2024 14:13
@kbond
Copy link
Member

kbond commented Apr 30, 2024

Thanks Simon.

@kbond kbond merged commit 138ae48 into symfony:2.x Apr 30, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Site ux.symfony.com Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants