Skip to content

[LiveComponent] Fix namespaces on documentation #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

mickaelblondeau
Copy link
Contributor

Q A
Bug fix? no
New feature? no
Issues
License MIT

The documentation shows this namespace: App\Components but the default configuration of twig_component uses App\Twig\Components

I then updated all the namespaces with the Twig part

@smnandre
Copy link
Member

Hi @mickaelblondeau ! Thank you for this PR :)

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Apr 29, 2024
@kbond
Copy link
Member

kbond commented Apr 30, 2024

Thank you Mickael, great first contribution!

@kbond kbond merged commit cb710f4 into symfony:2.x Apr 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LiveComponent Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants