[TwigComponent] Allow input props to have the same name as context variables

[squrious]

Q	A
Bug fix?	yes
New feature?	no
Issues	-
License	MIT

It looks like #1652 introduced an issue with input props and parent context.

If:

• A component prop has the same name as a variable in the parent context
• The context variable is used to set the prop value as an input prop
• The component is rendered with the embed strategy

Then, the default value of the prop is used instead of the one passed to the component.

Example:

{# templates/components/Hello.html.twig #}

{% props name = 'John' %}
<div {{ attributes }}>
    Hello {{ name }}!
</div>

Render embedded

{% set name = 'Bryan' %}
<twig:Hello :name="name"></twig:Hello>

Wrong output:

<div>
    Hello John!
</div>

Render with function

{% set name = 'Bryan' %}
<twig:Hello :name="name" />

Correct output:

<div>
    Hello Bryan!
</div>

[smnandre]

❤️

[squrious]

Good fabbot

[smnandre]

Suggested change

	['__context' => array_filter($context, static fn ($key) => !\in_array($key, $propsKeys), \ARRAY_FILTER_USE_KEY)],
	['__context' => array_diff_key($context, $props)],

(I have a doubt)

[squrious]

Thanks for the tip! Fixed :)

[smnandre]

Maybe add a test case when name is passed with "null" ?

[squrious]

Thanks for the review @smnandre!

Maybe add a test case when name is passed with "null" ?

I wasn't sure about that. If you pass null, the prop is considered unset, so yes we can't pass a null value explicitly.

But there is a systematic use of isset in the PropsNode class, so I thought it was intended for some reason. Would you prefer to replace them with array_key_exists?

[smnandre]

Oh we lost some hair with @WebMamba last time, i will trust you on this ^^

[WebMamba]

Thanks a lot @squrious, I over thinking this part, it's much simpler and less buggy! Great job!

[kbond]

This is great, thanks Nicolas!