Skip to content

[TwigComponent] Remove wrongly added configuration #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2024

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented May 3, 2024

Q A
Bug fix? yes
New feature? no
Issues Fix #...
License MIT

This configuration parameter has been added by mistake in 0284c0a#diff-d57f69d9cc81e78af30634d1b88a735542ffb1c98c782269abb604a85b727ce1R189-R191

I checked everywhere in this component and there is no usage of it

(it seems to come from a Stimulus config copy/paste during the 6.4 chaos rush)

@carsonbot carsonbot added Bug Bug Fix TwigComponent Status: Needs Review Needs to be reviewed labels May 3, 2024
@smnandre smnandre requested a review from kbond May 3, 2024 06:42
@smnandre
Copy link
Member Author

smnandre commented May 3, 2024

Failures unrelated (Twig 3.9 deprecations)

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels May 3, 2024
@kbond kbond force-pushed the twig/remove-configuration-bug branch from e469c59 to 239425d Compare May 8, 2024 13:29
@kbond
Copy link
Member

kbond commented May 8, 2024

Thanks Simon.

@kbond kbond merged commit d4e73c6 into symfony:2.x May 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug Fix Status: Reviewed Has been reviewed by a maintainer TwigComponent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants