Skip to content

[Site] Clean templates #1827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2024
Merged

[Site] Clean templates #1827

merged 1 commit into from
May 8, 2024

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented May 6, 2024

Q A
Bug fix? no
New feature? no
Issues Fix #
License MIT

Replaces #1822

All the clean / fixes / CS (without removing the light mode for now)

@carsonbot carsonbot added Site ux.symfony.com Status: Needs Review Needs to be reviewed labels May 6, 2024
@smnandre smnandre mentioned this pull request May 6, 2024
Closed
@smnandre smnandre requested a review from kbond May 6, 2024 05:23
@smnandre smnandre mentioned this pull request May 6, 2024
Merged
@kbond kbond force-pushed the site/clean-templates branch from 435f5d5 to 3de425e Compare May 8, 2024 13:27
@kbond
Copy link
Member

kbond commented May 8, 2024

Thanks Simon.

@kbond kbond merged commit bd53d73 into symfony:2.x May 8, 2024
3 of 4 checks passed
kbond added a commit that referenced this pull request May 8, 2024
@kbond
minor #1831 [Site] Icons colors (smnandre)
373bfe8 
This PR was merged into the 2.x branch.

Discussion
----------

[Site] Icons colors

* don't invert colored icons
* add 3 icon set cards
* re-add SVG code highlighting

(to merge after #1827)

Commits
-------

438fa01 [Site] Icons colors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbond kbond Awaiting requested review from kbond

Assignees
No one assigned
Labels
Site ux.symfony.com Status: Needs Review Needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smnandre @kbond @carsonbot