Skip to content

[LazyImage] Fix code block rendering in docs #1876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

mttsch
Copy link
Contributor

@mttsch mttsch commented May 30, 2024

Q A
Bug fix? no
New feature? no
Issues
License MIT

@mttsch
Copy link
Contributor Author

mttsch commented May 30, 2024

Currently renders incorrectly on website (https://symfony.com/bundles/ux-lazy-image/current/index.html#customizing-images-fetching):

Screenshot 2024-05-30 at 09 21 13

I did not check how it will render after this change!

@Kocal
Copy link
Member

Kocal commented May 30, 2024

Hi, I've used :: because the linter was not happy about it:

Please do not use ".. code-block:: php", use "::" instead.

And so you have the same issue https://github.com/symfony/ux/actions/runs/9298650239/job/25590944633?pr=1876

IDK how to fix it properly tho

@Kocal
Copy link
Member

Kocal commented May 30, 2024

Hum, maybe removing the newline between .. :: and namespace App\BlurHash;?

@mttsch mttsch force-pushed the bugfix/LazyImage-docs branch from 0d0abba to 676f8d5 Compare May 30, 2024 10:22
@mttsch
Copy link
Contributor Author

mttsch commented May 30, 2024

When checking for existing examples, I mistakenly used examples from the vendor folder. Now I searched for existing examples that are not in vendor, though I still have not checked the built result.

@kbond
Copy link
Member

kbond commented Jun 1, 2024

Thank you Matthias.

@kbond kbond merged commit 2c360c6 into symfony:2.x Jun 1, 2024
3 checks passed
@mttsch mttsch deleted the bugfix/LazyImage-docs branch June 2, 2024 04:12
@Kocal
Copy link
Member

Kocal commented Jun 3, 2024

When checking for existing examples, I mistakenly used examples from the vendor folder. Now I searched for existing examples that are not in vendor, though I still have not checked the built result.

Looks like you were right, the code block is now properly displayed, thanks :)
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants