[Autocomplete] Fix invalid createQueryBuilder code example #2470
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace with creating it from the entity repository
smnandre
reviewed
Dec 30, 2024
src/Autocomplete/doc/index.rst
Outdated
| @@ -316,7 +316,7 @@ the consequent renders, the default ``query_builder`` will be used:: | |||
| ->add('food', FoodAutocompleteField::class, [ | |||
| 'query_builder' => function (EntityRepository $er) { | |||
| return $er->createQueryBuilder('o') | |||
| ->andWhere($qb->expr()->notIn('o.id', [$currentFoodId])); | |||
| ->andWhere($er->createQueryBuilder()->expr()->notIn('o.id', [$currentFoodId])); | |||
There was a problem hiding this comment.
Nice catch, thank you!
I think we should use the same style than later in the file (L369..) as i fear calling createQueryBuilder twice could be confusing.
$qb = $er->createQueryBuilder('o');
return $qb->andWhere($qb->expr()->notIn('o.id', [$currentFoodId]));
smnandre
changed the title
|
Status: Needs Work |
carsonbot
added
Status: Needs Work
carsonbot
added
Status: Needs Review
|
Thank you @tacman. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace with creating it from the entity repository