[Map][Translator][Turbo] Ensure TypeScript code is valid #2562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Packages dist files size differenceThanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
|
|||||||||||||||||||||
Kocal
commented
Feb 10, 2025
| @@ -40,6 +40,7 @@ | |||
| "devDependencies": { | |||
| "@googlemaps/js-api-loader": "^1.16.6", | |||
| "@hotwired/stimulus": "^3.0.0", | |||
| "@symfony/ux-map": "workspace:*", | |||
There was a problem hiding this comment.
It has no impact on dist/ files, either for Webpack Encore or AssetMapper. Here we are telling Yarn that package @symfony/ux-map is a "parent" package of @symfony/ux-google-map, in order to fix the topological order (see https://yarnpkg.com/cli/workspaces/foreach)
Kocal
force-pushed
the
fix-ts-types-when-building
branch
2 times, most recently
from
c600924 to
c903aec
Compare
Kocal
changed the title
Kocal
force-pushed
the
fix-ts-types-when-building
branch
from
c903aec to
641ea02
Compare
…sure `build` and `test` scripts respect workspaces topoligy
Kocal
force-pushed
the
fix-ts-types-when-building
branch
from
641ea02 to
ddbabd6
Compare
|
Reaction in one word: thank-you-Kocal-this-is-very-very-nice-and-yes-i-cheated-a-bit 😎 |
smnandre
approved these changes
Feb 12, 2025
carsonbot
added
Status: Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fail the build (and the CI) when TypeScript code contain issues.
I also fixed existing issues in Map, Translator, and Turbo code.
Before:
After: