-
-
Notifications
You must be signed in to change notification settings - Fork 356
[TwigComponent] Fix ComponentTokenParser on 32-bits #2572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TwigComponent] Fix ComponentTokenParser on 32-bits #2572
Conversation
smnandre
commented
Feb 12, 2025
Q | A |
---|---|
Bug fix? | yes |
New feature? | no |
Issues | Fix #2568 |
License | MIT |
- 64-bit users get the original behavior
- 32-bit users get the fix to prevent overflow issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @smnandre, I tested the patch on a 32-bit system. Unfortunately, console clear:cache
failed again with:
syntax error, unexpected token "-", expecting "{"
That’s due to a compiled template component class with a -
in the class name.
My suggestion solves this problem.
Thanks a lot! I've commited your suggested code. Tell me if this is ok for you and LGTM :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Note: test failures are related to deprecations in Twig, that will require a dedicated PR |
312b699
to
8803614
Compare