Skip to content

[StimulusBundle] Fix lazy load Stimulus controllers with Turbo #2590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

smnandre
Copy link
Member

Q A
Bug fix? yes
New feature? no
Issues Fix #2576 / maybe #2583
License MIT

Partial revert of some changes to fix issues with Turbo and lazyload Stimulus controllers

@carsonbot carsonbot added Bug Bug Fix Status: Needs Review Needs to be reviewed labels Feb 22, 2025
Copy link

github-actions bot commented Feb 22, 2025

📊 Packages dist files size difference

Thanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
Please review the changes and make sure they are expected.

FileBefore (Size / Gzip)After (Size / Gzip)
StimulusBundle
loader.js 3.8 kB / 1.01 kB 3.55 kB-7% 📉 / 1004 B-3% 📉

@Kocal
Copy link
Member

Kocal commented Feb 24, 2025

I was able to reproduce the issue locally, and using your PR fixed the issue:

Enregistrement.de.l.ecran.2025-02-24.a.23.28.50.mov

@Kocal Kocal changed the title fix: lazy load Stimulus controllers with Turbo [StimulusBundle] Fix lazy load Stimulus controllers with Turbo Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug Fix Status: Reviewed Has been reviewed by a maintainer StimulusBundle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[StimulusBundle] Lazy controllers not loaded with Turbo
3 participants