Document src/**/assets/README.md files about direct installation and recommended alternatives.
#2612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d recommended alternatives.
carsonbot
added
Bug
Kocal
added
docs
Kocal
added a commit
that referenced
this pull request
Mar 1, 2025
…sions) can be installed/used inside an Encore App (Kocal) This PR was squashed before being merged into the 2.x branch. Discussion ---------- [CI] Ensure JS packages (either from `vendor/` or npm versions) can be installed/used inside an Encore App | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Follow #2612 This PR add a new E2E test to ensure, inside a Symfony app, that our JS packages (either from `vendor/symfony/ux-*` or from standalone ones from `src/*/assets`/npm) are usable inside a real application using a `package.json` and Encore. Commits ------- 2a65cb2 [CI] Add "test-app-encore-app" job, to ensure that JS packages are usable from `vendor/symfony/*` or from standalone JS packages 3720ba6 Update build-packages.php to cover `test_apps/*/` c7debbf [TestApps] Introduce an EncoreApp with all UX PHP and JS packages required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow #2595, related to #2575