[Map] Add Circle support #2838
Merged
[Map] Add Circle support #2838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
reviewed
Jun 13, 2025
Valmonzo
force-pushed
the
feat/add-circle-support-on-map
branch
from
9189aa7 to
a9aebb0
Compare
📊 Packages dist files size differenceThanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
|
||||||||||||||||||||||||||||||
carsonbot
added
Feature
Kocal
approved these changes
Jun 13, 2025
Comment on lines
+211
to
+212
| Add Circles | ||
| ~~~~~~~~~~~ |
There was a problem hiding this comment.
Not for this PR, but I feel like we should start to link Google Maps/Leaflet documentation for markers, polygones, etc...
carsonbot
added
Status: Reviewed
Kocal
force-pushed
the
feat/add-circle-support-on-map
branch
from
88f60dd to
0839a1d
Compare
|
Thank you @Valmonzo. |
Kocal
added a commit
that referenced
this pull request
Jun 22, 2025
…and `Rectangle` (Kocal) This PR was merged into the 2.x branch. Discussion ---------- [Map][Google] Fix `InfoWindow` compatibility with `Circle` and `Rectangle` | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Docs? | no <!-- required for new features --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Looks like using `InfoWindow` with Google Maps `Circle` and `Rectangle` has not been tested when working on #2845 and #2838 :( Commits ------- ac68141 [Map][Google] Fix `InfoWindow` compatibility with `Circle` and `Rectangle`
Kocal
added a commit
that referenced
this pull request
Jun 23, 2025
…tributes (Valmonzo) This PR was merged into the 2.x branch. Discussion ---------- [Map] Update test to include circle and rectangle data attributes | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Docs? | no | Issues | | License | MIT Fix typo from #2845 and missing circles attributes from #2838 , sorry `@Kocal` 😞 Commits ------- 2b65124 [Map] Update test to include circle and rectangle data attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Circle support for map (Googlemap and leaflet)