Skip to content

[Map][Google] Fix race conditions when loading Google Maps API, when rendering >=2 maps #2854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2025
Merged

[Map][Google] Fix race conditions when loading Google Maps API, when rendering >=2 maps #2854

merged 1 commit into from
Jun 21, 2025

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Jun 21, 2025

Q A
Bug fix? yes
New feature? no
Docs? no
Issues Fix #2846
License MIT
Enregistrement.de.l.ecran.2025-06-21.a.23.27.18.mov

@carsonbot carsonbot added Bug Bug Fix Map Status: Needs Review Needs to be reviewed labels Jun 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

📊 Packages dist files size difference

Thanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
Please review the changes and make sure they are expected.

FileBefore (Size / Gzip)After (Size / Gzip)
Map (Bridge Google)
map_controller.js 12.22 kB / 2.65 kB 12.54 kB+3% 📈 / 2.72 kB+3% 📈

@Kocal Kocal mentioned this pull request Jun 21, 2025
Closed
@Kocal Kocal merged commit 524aa1d into symfony:2.x Jun 21, 2025
21 of 22 checks passed
@Kocal Kocal deleted the 2846-map-multiple-google-maps branch June 21, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Bug Fix Map Status: Needs Review Needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Map] Google Maps rendering fails when rendering more than 1 map
2 participants
@Kocal @carsonbot