Fix history uncluttering when Bash version is >= 5.1 #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Bash version 5.1, the behaviour of HISTCMD has been changed and it breaks history uncluttering. This commit solves this problem by checking the Bash major version and by using the appropriate command to unclutter the history.
montag451
force-pushed
the
history-uncluttering
branch
from
cab8e7f to
0e086cf
Compare
Contributor
Author
|
I have no clue why the CI tests are failing. On my machine I tested my changes against Bash 4.4, Bash 5.0, Bash 5.1 and Bash 5.2 and it works fine (the current version of emacs-bash-completion fails with Bash 5.1 and 5.2) |
Owner
|
Thank you for the patch! I'll try it out! The CI tests failing have nothing to do with the patch. It looks like the CI is broken. I'm having a look. |
Owner
|
I tested manually and everything looks fine. Again, thank you for the fix! I'm going to merge this change and fix the Cl afterwards. |
Contributor
Author
|
Thx for your quick merge and for this wonderful package! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Bash version 5.1, the behaviour of HISTCMD has been changed and it breaks history uncluttering. This commit solves this problem by checking the Bash major version and by using the appropriate command to unclutter the history.