Skip to content

android: log when VPN not established #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

android: log when VPN not established #641

merged 1 commit into from
Apr 17, 2025

Conversation

kari-ts
Copy link
Collaborator

@kari-ts kari-ts commented Apr 16, 2025

@review-ai-agent review.ai agent
Copy link

review-ai-agent bot commented Apr 16, 2025 •
edited
Loading

Pull Request Revisions

RevisionDescription
r1
Added logging for nil parcelFDEnhanced error logging in updateTUN method when ParcelFileDescriptor is nil during VPN establishment
✅ AI review completed for r1
Help React with emojis to give feedback on AI-generated reviews:
  • 👍 means the feedback was helpful and actionable
  • 👎 means the feedback was incorrect or unhelpful
💬 Replying to feedback with a comment helps us improve the system. Your input also contributes to shaping future interactions with the AI reviewer.

We'd love to hear from you—reach out anytime at [email protected].

@kari-ts kari-ts requested a review from barnstar April 16, 2025 23:47
@kari-ts kari-ts merged commit 6e856b1 into main Apr 17, 2025
5 checks passed
@kari-ts kari-ts deleted the kari/vpnlogs branch April 17, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barnstar barnstar barnstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kari-ts @barnstar