Add drop-shadow-* color support
#17434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
force-pushed
the
feat/drop-shadow-colors
branch
from
20476ae to
b9f294e
Compare
thecrypticace
force-pushed
the
feat/drop-shadow-colors
branch
from
b9f294e to
a4872d9
Compare
thecrypticace
force-pushed
the
feat/drop-shadow-colors
branch
from
a4872d9 to
8cb6505
Compare
|
@adamwathan Would be good to get your eyes on the implementation to see if there's anything you'd prefer to change about this. They work mostly the same as the existing text-shadow, inset-shadow, and shadow utilities. |
RobinMalfait
reviewed
Apr 1, 2025
Comment on lines
4388
to
4392
| `drop-shadow(${replaceShadowColors( | ||
| v, | ||
| alpha, | ||
| (color) => `var(--tw-drop-shadow-color, ${color})`, | ||
| )})`, |
There was a problem hiding this comment.
I think the API changed here because this is passing 3 values instead of 2
There was a problem hiding this comment.
Ah I think it's because I pressed the update button (because of conflicts in the CHANGELOG.md file)
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for two things:
drop-shadow-{color}utilities which can be used to control the filder drop shadow colordrop-shadow-*/{alpha}utilities which can be used to control the intensity of the drop shadowNote that drop-shadow-* utilities without a modifier use variables from your theme.
If you opt into using drop shadow colors or drop-shadow "intensity" utilities we will inline these values into your CSS when using a drop shadow color or drop shadow intensity utility and as such can't be changed by changing the theme variables on a per-element/tree basis.