Skip to content

Fix multi-value arbitrary inset shadow #17523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 3, 2025
Merged

Fix multi-value arbitrary inset shadow #17523

merged 3 commits into from
Apr 3, 2025
+30 −3

Conversation

wongjn
Copy link
Collaborator

@wongjn wongjn commented Apr 3, 2025 •
edited by philipp-spiess
Loading

Fixes #17520

Fixes multi-value inset shadows to apply the inset prefix to each component instead of only the first.

Feel free to make the code nicer 😄

Test plan

Ensure that a multi-value inset shadow now applies each shadow inset:
Screenshot 2025-04-03 at 10 50 29

@wongjn wongjn requested a review from a team as a code owner April 3, 2025 08:15
philipp-spiess
philipp-spiess reviewed Apr 3, 2025
View reviewed changes
Copy link
Member

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this makes sense. Let me just check this out locally and see if the repro now works as expected 🙂

@philipp-spiess philipp-spiess merged commit 80f9578 into tailwindlabs:main Apr 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipp-spiess philipp-spiess philipp-spiess approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inset-shadow-[spec1,spec2] renders all but the first shadow spec outset, not inset
2 participants
@wongjn @philipp-spiess