Update contribution docs #17911
Merged
Update contribution docs #17911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
reviewed
May 7, 2025
philipp-spiess
force-pushed
the
chore/update-contribution-docs
branch
from
f469132 to
4130ba1
Compare
RobinMalfait
reviewed
May 7, 2025
Co-authored-by: Robin Malfait <[email protected]>
philipp-spiess
force-pushed
the
chore/update-contribution-docs
branch
from
a053541 to
000d02b
Compare
RobinMalfait
approved these changes
May 8, 2025
There was a problem hiding this comment.
I like it, one question though now that I see the commands involved and I run out of habit anyway.
Should we add some pretest, pretdd, ... scripts to run pnpm build so you don't have to do that all the time?
Or a preinstall in the root to run a pnpm build to get the initial build going?
Up to you, this is already an improvement. 💪
|
@RobinMalfait Hmm, unsure. Initial gut is that you don't always want a build before running these commands but turbo will bail out early anyway if there are no changes. Let's leave it separate for now and see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the contribution docs to make it easier for anyone contributing to Tailwind CSS.