Skip to content

Fix compatibility with Windows #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 8, 2020
Merged

Fix compatibility with Windows #2

merged 5 commits into from
Aug 8, 2020

Conversation

8ctopus
Copy link

@8ctopus 8ctopus commented Aug 5, 2020

Solves all Windows related issues I could find (#1), without breaking functionality in linux based systems.
Works in both classic cmd.exe and mintty.

@8ctopus 8ctopus mentioned this pull request Aug 5, 2020
@talhasch talhasch merged commit 4b59bbd into talhasch:master Aug 8, 2020
@talhasch
Copy link
Owner

talhasch commented Aug 8, 2020

@8ctopus thanks for contribution!

@talhasch
Copy link
Owner

talhasch commented Aug 8, 2020

@8ctopus it doesn't work with macos. error message i get:

Could not decode json: Syntax error
curl result: 0 {"time_namelookup": 0,030375,"time_connect": 0,047081,"time_appconnect": 0,131314,"time_pretransfer": 0,131455,"time_redirect": 0,000000,"time_starttransfer": 0,225138,"time_total": 0,228472,"speed_download": 55324,000,"speed_upload": 0,000}

Somehow curl returns wrong/incompatible json format.

@8ctopus
Copy link
Author

8ctopus commented Aug 10, 2020

@talhasch Sorry about that, I don't have a mac to test on but I did successfully test in Alpine linux. I'll send an updated pull request that should work on Mac later today.

@8ctopus 8ctopus deleted the windows-compatibility branch August 11, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants