redo state algorithm #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did test this with the SKU 377 encoder and a Feather M0. |
tannewt
approved these changes
Jun 1, 2018
|
This breaks pirkey |
|
That is weird because it compiles fine in my clone of your repo with those changes: |
|
Weird that its breaking will merge and make sure its fixed for the adafruit PR. |
tannewt
pushed a commit
that referenced
this pull request
Aug 16, 2018
tannewt
pushed a commit
that referenced
this pull request
Oct 18, 2018
tannewt
pushed a commit
that referenced
this pull request
Nov 20, 2019
Removed robohatmm1_m0 from build.
tannewt
pushed a commit
that referenced
this pull request
Dec 26, 2019
stm32 explicitily enable/disable vbus sense, fix warning
tannewt
pushed a commit
that referenced
this pull request
Feb 13, 2021
Merge latest CircuitPython changes (6.0.0-rc.1)
tannewt
pushed a commit
that referenced
this pull request
Apr 23, 2021
tannewt
pushed a commit
that referenced
this pull request
Jun 24, 2021
asan considers that memcmp(p, q, N) is permitted to access N bytes at each
of p and q, even for values of p and q that have a difference earlier.
Accessing additional values is frequently done in practice, reading 4 or
more bytes from each input at a time for efficiency, so when completing
"non_exist<TAB>" in the repl, this causes a diagnostic:
==16938==ERROR: AddressSanitizer: global-buffer-overflow on
address 0x555555cd8dc8 at pc 0x7ffff726457b bp 0x7fffffffda20 sp 0x7fff
READ of size 9 at 0x555555cd8dc8 thread T0
#0 0x7ffff726457a (/usr/lib/x86_64-linux-gnu/libasan.so.5+0xb857a)
#1 0x555555b0e82a in mp_repl_autocomplete ../../py/repl.c:301
#2 0x555555c89585 in readline_process_char ../../lib/mp-readline/re
#3 0x555555c8ac6e in readline ../../lib/mp-readline/readline.c:513
#4 0x555555b8dcbd in do_repl /home/jepler/src/micropython/ports/uni
#5 0x555555b90859 in main_ /home/jepler/src/micropython/ports/unix/
#6 0x555555b90a3a in main /home/jepler/src/micropython/ports/unix/m
#7 0x7ffff619a09a in __libc_start_main ../csu/libc-start.c:308
#8 0x55555595fd69 in _start (/home/jepler/src/micropython/ports/uni
0x555555cd8dc8 is located 0 bytes to the right of global variable
'import_str' defined in '../../py/repl.c:285:23' (0x555555cd8dc0) of
size 8
'import_str' is ascii string 'import '
Signed-off-by: Jeff Epler <[email protected]>
tannewt
pushed a commit
that referenced
this pull request
Nov 30, 2022
Typo in docs for supervisor.ticks_ms()
tannewt
pushed a commit
that referenced
this pull request
Sep 29, 2023
Add board def for MagiClick S3
tannewt
pushed a commit
that referenced
this pull request
Aug 8, 2024
Added additional pin names to pins.c for vidi_x board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a redo of the rotary encoder algorithm. It was inspired by some simpler versions I found last night, like: https://www.mikrocontroller.net/articles/Drehgeber#Dekoder_f.C3.BCr_Drehgeber_mit_wackeligen_Rastpunktenr (not that I can read German; hurray Google Translate)
But I haven't see anyone else do the
quarter_countbusiness, which I think is an easier way to keep track of the history of the previous states. It's easier to understand than the bigger state tables in https://github.com/buxtronix/arduino/blob/master/libraries/Rotary/Rotary.cpp.