-
Notifications
You must be signed in to change notification settings - Fork 10
CHI-2916 switchboarding #3040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
CHI-2916 switchboarding #3040
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, this looks awesome to me! I like the approach you are taking to implement the feature.
Sorry to leave so many comments, some of them are to make sure we are addressing edge cases, some of them are just questions.
One question I want to make that does not fits any of the files: Do we really need to have a Redux state that mirrors the sync document state? Maybe the sync document itself can carry #2991 (comment)loading
and error
information as well as the data required for switchboard, and having the Redux state would be unnecessary?
I LOVE the implementation you have around all of this using custom hooks (useSubscribeToSwitchboardState
and useToggleSwitchboardingForQueue
), which make me wonder, maybe just the hooks and the sync client could handle everything without Redux?
Description
This PR introduces the Switchboarding allowing supervisors to enable and manage switchboarding for a specific queue.
Checklist
Other Related Issues
None
Verification steps
AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P