#225: Fixing incorrect US page size #226
Conversation
corrected the usLetter page height and usLedger page width to reflect 11inx72dpi
|
Can you please rebase your branch on the newest develop? I fixed a file reference, so that the unit tests can run again |
corrected the usLetter page height and usLedger page width to reflect 11inx72dpi
corrected the usLetter page height and usLedger page width to reflect 11inx72dpi
|
i am afraid there might be something i am not doing right since it seems the continuous integration test keeps failing. i've relied on googling how to do a rebase but maybe that isn't the right way to do it :( |
|
No, it's alright, you just need to fix the Unit Tests. Open "TPPDF.xcodeproj" in the root, and you should be able to run the tests from |
| /* End PBXAggregateTarget section */ | ||
|
|
||
| /* Begin PBXBuildFile section */ | ||
| D477C4C224C45C780097C2AB /* PDFTableCalculatedCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = D477C4C124C45C780097C2AB /* PDFTableCalculatedCell.swift */; }; |
There was a problem hiding this comment.
Please revert removing this, this will exclude the file from the project
| /* End PBXContainerItemProxy section */ | ||
|
|
||
| /* Begin PBXFileReference section */ | ||
| D477C4C124C45C780097C2AB /* PDFTableCalculatedCell.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = PDFTableCalculatedCell.swift; sourceTree = "<group>"; }; |
| D4803C3724703E5300DDA039 /* Table */ = { | ||
| isa = PBXGroup; | ||
| children = ( | ||
| D477C4C124C45C780097C2AB /* PDFTableCalculatedCell.swift */, |
| D4803D1424703E5300DDA039 /* PDFPageLayout.swift in Sources */, | ||
| D4803D2024703E5300DDA039 /* PDFTableCellStyle.swift in Sources */, | ||
| D4803CFF24703E5300DDA039 /* PDFGenerator+Generation.swift in Sources */, | ||
| D477C4C224C45C780097C2AB /* PDFTableCalculatedCell.swift in Sources */, |
reinstate file in unit tests
fixed Pagefornat test definition to the correct usLetter page size
|
thank you for your help.. it turns out i also had to update the test file PDFPageFormat+SizeConstant_Spec.swift with the updated usLetter size info thanks for your help... |
|
Thanks for the changes, can you please undo the changes in the project.pbxproj I commented above, so I can merge the branch afterwards? |
|
Philip... if i put those lines back in if i remove them from the project file, then all the test pass. what am i doing wrong ? for now, the lines are back in... |
|
Alright, I don't get it why it is failing, as the develop branch itself is working (maybe you forked after I fixed that issue). Thanks for your contribution |
* Added macOS compatibility to tests (#224) * Fixed missing file ref * #225: Fixing incorrect US page size (#226) Corrected the usLetter page height and usLedger page width to reflect 11inx72dpi * Fixed missing file ref * Updated changelog Co-authored-by: Sami Khoury <[email protected]>
2 participants
corrected the usLetter page height and usLedger page width to reflect 11inx72dpi
closes #225