Standardize rollup configs with a central config generator #1102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `tools/make_rollup_config.mjs` to standardize rollup configs among models. Use the script to generate Blazeface's config. Additionally, upgrade TypeScript in the root package.json and in Blazeface to 4.9.5.
mattsoulanille
force-pushed
the
standardize_rollup
branch
from
9022812 to
22ca04f
Compare
mattsoulanille
force-pushed
the
standardize_rollup
branch
from
b1cdda8 to
c62ae7a
Compare
mattsoulanille
changed the title
mattsoulanille
requested review from
chunnienc
and removed request for
pyu10055
chunnienc
approved these changes
Feb 21, 2023
Linchenn
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
tools/make_rollup_config.mjsto standardize rollup configs among models. Use the script to generate Blazeface's config.Additionally, upgrade TypeScript in the root package.json and in Blazeface to 4.9.5.
This change is