Add info and ok endpoint and refactor code #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #358
Codecov Report
@@ Coverage Diff @@
## main #360 +/- ##
==========================================
+ Coverage 69.77% 70.02% +0.24%
==========================================
Files 11 11
Lines 3841 3806 -35
==========================================
- Hits 2680 2665 -15
+ Misses 1161 1141 -20
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
It had the exact same implementation as get_documents except that it added an extra argument.
Checking string constants each time is in my opinion not good. We should use proper types for this like the GraphType enum. I also made sure it is backwards compatible. Calling the functions the old way will work fine.
_ref_extract was not called anywhere inside the codebase and no docs even mention it. The tests don't call it as well.
This test case was not covered
It was used for type hinting but not imported
GavinMendelGleason
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #358