Skip to content

Change Requests to use a session, saving on latency for connect #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 2, 2023

Conversation

GavinMendelGleason
Copy link
Member

This PR attempts to use request sessions to get around the connection latency which occurs on first connect.

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #380 (8f7e88f) into main (eda31ca) will increase coverage by 1.11%.
The diff coverage is 92.00%.

@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
+ Coverage   70.54%   71.65%   +1.11%     
==========================================
  Files          11       43      +32     
  Lines        3812     4040     +228     
==========================================
+ Hits         2689     2895     +206     
- Misses       1123     1145      +22     
Impacted Files Coverage Δ
terminusdb_client/woql_type.py 82.71% <ø> (ø)
terminusdb_client/client/Client.py 83.47% <91.11%> (+0.06%) ⬆️
terminusdb_client/schema/schema.py 78.55% <100.00%> (+0.18%) ⬆️
terminusdb_client/tests/woqljson/woqlReJson.py 100.00% <0.00%> (ø)
...nusdb_client/tests/integration_tests/mock_jsons.py 100.00% <0.00%> (ø)
terminusdb_client/tests/AllServerRecords.py 100.00% <0.00%> (ø)
terminusdb_client/tests/mockResponse.py 100.00% <0.00%> (ø)
terminusdb_client/tests/woqljson/woqlDeleteJson.py 100.00% <0.00%> (ø)
...minusdb_client/tests/integration_tests/conftest.py 86.95% <0.00%> (ø)
terminusdb_client/tests/woqljson/woqlIdgenJson.py 100.00% <0.00%> (ø)
... and 26 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rrooij rrooij merged commit 1953ddb into main Feb 2, 2023
@rrooij rrooij deleted the requests_session branch February 2, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants