Skip to content

Fix conversion of sys:JSON type schema to Python #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2023

Conversation

rrooij
Copy link
Contributor

@rrooij rrooij commented May 30, 2023

If a class contained a "sys:JSON" property, it wouldn't convert to a normal Python class as it should.

Fixes issue #397

If a class contained a "sys:JSON" property, it wouldn't
convert to a normal Python class as it should.

Fixes issue #397
Copy link
Member

@GavinMendelGleason GavinMendelGleason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stellar work

@GavinMendelGleason GavinMendelGleason merged commit b3af249 into main May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #400 (e266989) into main (fd967e4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #400   +/-   ##
=======================================
  Coverage   71.40%   71.40%           
=======================================
  Files          43       43           
  Lines        4071     4071           
=======================================
  Hits         2907     2907           
  Misses       1164     1164           
Impacted Files Coverage Δ
terminusdb_client/woql_type.py 82.71% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@GavinMendelGleason GavinMendelGleason deleted the fix_json_schema_bug branch May 30, 2023 12:06
rrooij added a commit that referenced this pull request Jun 7, 2023
If a class contained a "sys:JSON" property, it wouldn't
convert to a normal Python class as it should.

Fixes issue #397
GavinMendelGleason pushed a commit that referenced this pull request Jun 23, 2023
* Fix docs and license

* Try to insert docs

* Use poetry

* Add commit message and author

* Remove the commit message and author

* Fix integration tests because of new requests lib (#395)

* Fix conversion of sys:JSON type schema to Python (#400)

If a class contained a "sys:JSON" property, it wouldn't
convert to a normal Python class as it should.

Fixes issue #397

* Add version 10.2.3

* Change title of application and description

* Get examples

* ci: don't do poetry interactively

* Fix parameters for patch function

* Only generate docs on version push or manual run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants