Skip to content

Replace project_prefix used in the integration tests #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

daniel-cit
Copy link
Contributor

@daniel-cit daniel-cit commented Mar 31, 2021

Replace project_prefix used in the integration tests.
Changed from tst to t01.

Collision of new projects with existing projects has become more frequent:

       Error: error creating project tst-p-shared-restricted-4d2b (tst-p-shared-restricted): googleapi: Error 409: Requested entity already exists, alreadyExists. If you received a 403 error, make sure you have the `roles/resourcemanager.projectCreator` permission
       
         on .terraform/modules/production.env.restricted_shared_vpc_host_project/modules/core_project_factory/main.tf line 65, in resource "google_project" "main":
         65: resource "google_project" "main" {    

@daniel-cit daniel-cit requested a review from a team as a code owner March 31, 2021 01:47
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @daniel-cit please switch base to main branch and rebase

@daniel-cit daniel-cit force-pushed the change-int-build-project-prefix branch from 5b947fa to c0ff1c5 Compare March 31, 2021 19:23
@daniel-cit daniel-cit changed the base branch from develop to master March 31, 2021 19:23
@daniel-cit
Copy link
Contributor Author

@bharathkkb I switched base to main branch and rebased the code

@daniel-cit daniel-cit requested a review from bharathkkb April 1, 2021 02:37
@bharathkkb bharathkkb merged commit ca67ba9 into terraform-google-modules:master Apr 1, 2021
@daniel-cit daniel-cit deleted the change-int-build-project-prefix branch April 1, 2021 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants