Initial set of modules #1
Conversation
|
@craigdbarber @sethvargo PTAL |
|
Great work! I'm adding @danawillow to this PR to solicit her feedback. She's the TLM for the gcp-terraform provider and would have a larger context to bring to bear. |
examples/gh-runner-gke-dind/main.tf
Outdated
| repo_owner = var.repo_owner | ||
| repo_url = var.repo_url | ||
| gh_token = var.gh_token | ||
| machine_type = "n1-highcpu-4" |
There was a problem hiding this comment.
Why hard code these VM configs? Suggest instead using variables with these as default values.
There was a problem hiding this comment.
This was something I was testing with, didn't intend to be part of the example. Just for some clarity- anything in examples/* is just an example of how to use the actual modules which reside in modules/*. I have used variables with sane defaults for the modules which will be what the end user directly uses.
examples/gh-runner-gke-dind/main.tf
Outdated
| repo_url = var.repo_url | ||
| gh_token = var.gh_token | ||
| machine_type = "n1-highcpu-4" | ||
| min_node_count = 3 |
There was a problem hiding this comment.
This was something I was testing with, didnt intend to be part of the example. Just for some clarity- anything in examples/* is just an example of how to use the actual modules which reside in modules/*. I have used variables with sane defaults for the modules which will be what the end user directly uses.
| value = module.runner-gke.kubernetes_endpoint | ||
| } | ||
|
|
||
| output "client_token" { |
There was a problem hiding this comment.
I use these in some of the inspec tests here.
bharathkkb
force-pushed
the
seed-tf-gh-runners
branch
from
d75ee86 to
598a38a
Compare
|
Hi All, |
…et/update-transient-deps Use GitHub sources to get master versions of dependencies
Added modules for
Added examples for