ASM module - Add a note about the mesh_id label on the GKE cluster
#1284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieu-benoit
requested review from
a team,
Jberlinsky and
bharathkkb
as code owners
|
Thanks for the PR! 🚀 |
bharathkkb
reviewed
Jun 8, 2022
Co-authored-by: Bharath KKB <[email protected]>
bharathkkb
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the ASM module is not using the
install_asmor theasmcli, the users need to manually set themesh_idon their GKE cluster in order to get the ASM features in the Google Cloud console working (Topology, etc.). Even if it's illustrated in the simple zonal with ASM example, it's not obvious for the ASM module user. We got some evidence internally about Googlers and customers having issues with that.I'm proposing adding an explicit note about that on the main ASM module doc.