Skip to content

fix: update incorrect KMS validation logic #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 11, 2023
Merged

Conversation

ocofaigh
Copy link
Contributor

@ocofaigh ocofaigh commented May 10, 2023

Description

update incorrect KMS validation logic

Types of changes in this PR

Changes that affect the core Terraform module or submodules

  • Bug fix
  • New feature
  • Dependency update

Changes that don't affect the core Terraform module or submodules

  • Examples or tests (addition or updates of examples or tests)
  • Documentation update
  • CI-related update (pipeline, etc.)
  • Other

Release required?

Identify the type of release. For information about the changes in a semantic versioning release, see Release versioning.

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

fix: update incorrect KMS validation logic


Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

  • Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author. The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).
  • Merge by using "Squash and merge".

@ocofaigh
Copy link
Contributor Author

@jor2 The pipelines comments have not been rolled out yet. Github is having an outage so pipeline is not triggering (https://www.githubstatus.com/)

@ocofaigh ocofaigh closed this May 11, 2023
@ocofaigh ocofaigh reopened this May 11, 2023
@ocofaigh
Copy link
Contributor Author

Test failed with what looks like backend IAM issue:

Error: [ERROR] Error retrieving resource group: An error occurred while performing the 'authenticate' step: Post "https://iam.cloud.ibm.com/identity/token": net/http: TLS handshake timeout null

Re-triggering the pipeline.

@ocofaigh ocofaigh merged commit a3ca341 into main May 11, 2023
@ocofaigh ocofaigh deleted the ocofaigh-patch-1 branch May 11, 2023 09:01
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants