Skip to content

use parameters_json for provision parameters #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 30, 2024
Merged

use parameters_json for provision parameters #325

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c2cb49f
use parameter_json for provision parameters
JunliWang Oct 28, 2024
895b464
skip kms_key_crn
JunliWang Oct 28, 2024
af7b0af
fmt
JunliWang Oct 28, 2024
f34c08e
convert number to string
JunliWang Oct 28, 2024
0c70b5b
not use paramters for non-enterprise plan
JunliWang Oct 28, 2024
e4b7b60
fix null parameters
JunliWang Oct 28, 2024
596745d
backwards compatible
JunliWang Oct 28, 2024
bb128dd
SKIP UPGRADE TEST
JunliWang Oct 28, 2024
a9fe18a
Merge branch 'main' into parameter-json
JunliWang Oct 29, 2024
1f39dd2
Merge branch 'main' into parameter-json
ocofaigh Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
not use paramters for non-enterprise plan
  • Loading branch information
@JunliWang
JunliWang committed Oct 28, 2024
commit 0c70b5b1702772a54a1ddd7ed8a21e66401987d8
2 changes: 1 addition & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ resource "ibm_resource_instance" "es_instance" {
}


parameters_json = var.kms_key_crn != null ? jsonencode(
parameters_json = var.plan != "enterprise-3nodes-2tb" ? jsonencode("{}") : var.kms_key_crn != null ? jsonencode(
{
service-endpoints = var.service_endpoints
throughput = tostring(var.throughput)
Expand Down