feat : Added Event Streams DA (Standard and Security-Enforced Variation) #397

Khuzaima05 · 2025-05-05T15:53:38Z

Description

Added Event Streams DA (Standard and Security-Enforced Variation)

issue: https://github.ibm.com/GoldenEye/issues/issues/13014 , https://github.ibm.com/GoldenEye/issues/issues/13484,
https://github.ibm.com/GoldenEye/issues/issues/13582

Release required?

No release
Patch release (x.x.X)
Minor release (x.X.x)
Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

If relevant, a test for the change is included or updated with this PR.
If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

Khuzaima05 · 2025-05-14T07:07:07Z

/run pipeline

Khuzaima05 · 2025-05-14T07:47:32Z

/run pipeline

Khuzaima05 · 2025-05-14T08:55:39Z

The upgrade test is failing because it clones the main branch and looks for the standard DA repo, which doesn’t exist in main yet—we’re introducing it in our current branch. The main branch only contains the quickstart and enterprise DAs, which we’ve are updating. Hence, we are skipping the upgrade test.

Khuzaima05 · 2025-05-14T08:58:00Z

/run pipeline

Khuzaima05 · 2025-05-14T14:10:19Z

/run pipeline

Khuzaima05 · 2025-05-14T16:39:27Z

/run pipeline

Khuzaima05 · 2025-05-14T17:03:25Z

Catalog Tile Overview and Features:

Security Enforced Variant:

Standard Variant:

Khuzaima05 · 2025-05-14T17:03:52Z

/run pipeline

Khuzaima05 · 2025-05-22T06:53:57Z

/run pipeline

ocofaigh · 2025-05-26T09:18:30Z

@Khuzaima05 Can we re-discuss the variation name "Standard" on tomorrow deep dive? I would really like to find a better name, but as we dicsussed "Fully configurable" doesn't make sense in this case

ocofaigh · 2025-05-27T12:50:41Z

As per deep dive, 2 variation names should be:

Quickstart
Security-enforced

Khuzaima05 · 2025-05-29T12:25:21Z

/run pipeline

Ak-sky

Left few comments, also need to update the URL in variables in existing code to use security-enforced instead of enterprise.
Few typos below needs to be fixed, PR in progress to add codespell to check for typos.

modules/fscloud/variables.tf:10: Steams ==> Streams
modules/fscloud/variables.tf:16: Steams ==> Streams
solutions/quickstart/README.md:45: Steams ==> Streams
solutions/quickstart/README.md:46: Steams ==> Streams
examples/basic/variables.tf:27: Steams ==> Streams
examples/fscloud/variables.tf:27: Steams ==> Streams
modules/fscloud/README.md:29: Steams ==> Streams
modules/fscloud/README.md:47: Steams ==> Streams
solutions/quickstart/main.tf:37: intance ==> instance, intense
README.md:164: Steams ==> Streams
solutions/security-enforced/variables.tf:66: Steams ==> Streams
solutions/security-enforced/variables.tf:72: Steams ==> Streams
solutions/security-enforced/README.md:5: wan't ==> want, wasn't
solutions/security-enforced/README.md:12: instace ==> instance
solutions/security-enforced/README.md:57: Steams ==> Streams
solutions/security-enforced/README.md:58: Steams ==> Streams
variables.tf:27: Steams ==> Streams
examples/complete/variables.tf:27: Steams ==> Streams
examples/complete/variables.tf:33: Steams ==> Streams
solutions/security-enforced/main.tf:169: intance ==> instance, intense
solutions/quickstart/variables.tf:76: Steams ==> Streams
solutions/quickstart/variables.tf:82: Steams ==> Streams

solutions/quickstart/variables.tf

solutions/security-enforced/catalogValidationValues.json.template

solutions/security-enforced/README.md

cra-config.yaml

solutions/quickstart/variables.tf

solutions/security-enforced/README.md

solutions/security-enforced/variables.tf

Co-authored-by: Akash Kumar <[email protected]>

ocofaigh

remove support_ibm tag - its not IBM supported yet, its only in community
add the following support statement:
"support_details": "This product is in the community registry, as such support is handled through the originated repo. If you experience issues please open an issue in the repository [https://github.com/terraform-ibm-modules/terraform-ibm-event-streams/issues](https://github.com/terraform-ibm-modules/terraform-ibm-event-streams/issues). Please note this product is not supported via the IBM Cloud Support Center.",

Khuzaima05 · 2025-06-12T05:18:22Z

remove support_ibm tag - its not IBM supported yet, its only in community

add the following support statement:
"support_details": "This product is in the community registry, as such support is handled through the originated repo. If you experience issues please open an issue in the repository [https://github.com/terraform-ibm-modules/terraform-ibm-event-streams/issues](https://github.com/terraform-ibm-modules/terraform-ibm-event-streams/issues). Please note this product is not supported via the IBM Cloud Support Center.",

Done

Khuzaima05 · 2025-06-12T05:18:52Z

Left few comments, also need to update the URL in variables in existing code to use security-enforced instead of enterprise.
Few typos below needs to be fixed, PR in progress to add codespell to check for typos.

modules/fscloud/variables.tf:10: Steams ==> Streams
modules/fscloud/variables.tf:16: Steams ==> Streams
solutions/quickstart/README.md:45: Steams ==> Streams
solutions/quickstart/README.md:46: Steams ==> Streams
examples/basic/variables.tf:27: Steams ==> Streams
examples/fscloud/variables.tf:27: Steams ==> Streams
modules/fscloud/README.md:29: Steams ==> Streams
modules/fscloud/README.md:47: Steams ==> Streams
solutions/quickstart/main.tf:37: intance ==> instance, intense
README.md:164: Steams ==> Streams
solutions/security-enforced/variables.tf:66: Steams ==> Streams
solutions/security-enforced/variables.tf:72: Steams ==> Streams
solutions/security-enforced/README.md:5: wan't ==> want, wasn't
solutions/security-enforced/README.md:12: instace ==> instance
solutions/security-enforced/README.md:57: Steams ==> Streams
solutions/security-enforced/README.md:58: Steams ==> Streams
variables.tf:27: Steams ==> Streams
examples/complete/variables.tf:27: Steams ==> Streams
examples/complete/variables.tf:33: Steams ==> Streams
solutions/security-enforced/main.tf:169: intance ==> instance, intense
solutions/quickstart/variables.tf:76: Steams ==> Streams
solutions/quickstart/variables.tf:82: Steams ==> Streams

Done

Khuzaima05 · 2025-06-12T05:23:07Z

/run pipeline

Khuzaima05 · 2025-06-12T06:27:27Z

/run pipeline

Khuzaima-Shakeel added 2 commits May 5, 2025 14:10

add : fully configurable version

431986d

updated json and DA

3ac6a6f

Khuzaima05 self-assigned this May 5, 2025

Khuzaima-Shakeel added 8 commits May 7, 2025 11:53

updated json

0bb63c1

updated json

5b66874

added security and standard DA

05e774d

Merge branch 'main' into issue_13014

1337681

added security and standard DA

f81428f

updated PR

1028852

updated PR

9b69d3a

fix conflict

84e265f

fix pipeline

6811dc4

Khuzaima05 changed the title ~~[WIP] feat : Added Event Streams DA (Fully configurable variations)~~ [WIP] feat : Added Event Streams DA (Standard and Security-Enforced Variation) May 14, 2025

fix ref_arch

b81e550

SKIP UPGRADE TEST

c50fcda

update catalog.json

c9d3c8e

Khuzaima05 marked this pull request as ready for review May 14, 2025 16:39

Khuzaima05 requested review from Ak-sky and akocbek as code owners May 14, 2025 16:39

Khuzaima05 changed the title ~~[WIP] feat : Added Event Streams DA (Standard and Security-Enforced Variation)~~ feat : Added Event Streams DA (Standard and Security-Enforced Variation) May 14, 2025

fix ibm_catalog

059c16f

update endpoint

ffc76d5

fix json

bd2d28e

Merge branch 'main' into issue_13014

a891041

updated variation name

fe695f1

Ak-sky requested changes Jun 5, 2025

View reviewed changes

Khuzaima05 and others added 15 commits June 11, 2025 10:43

Update solutions/quickstart/variables.tf

f6d357c

Co-authored-by: Akash Kumar <[email protected]>

Update solutions/security-enforced/catalogValidationValues.json.template

4573a54

Co-authored-by: Akash Kumar <[email protected]>

Update cra-config.yaml

918c2e6

Co-authored-by: Akash Kumar <[email protected]>

Update cra-config.yaml

4ae7a1a

Co-authored-by: Akash Kumar <[email protected]>

Update ibm_catalog.json

e91293f

Co-authored-by: Akash Kumar <[email protected]>

Update ibm_catalog.json

c11cc2f

Co-authored-by: Akash Kumar <[email protected]>

Update ibm_catalog.json

8971ad1

Co-authored-by: Akash Kumar <[email protected]>

Update solutions/quickstart/variables.tf

d722813

Co-authored-by: Akash Kumar <[email protected]>

Update ibm_catalog.json

ff0d8f8

Co-authored-by: Akash Kumar <[email protected]>

Update solutions/security-enforced/variables.tf

88f221b

Co-authored-by: Akash Kumar <[email protected]>

Update solutions/security-enforced/variables.tf

c55b841

Co-authored-by: Akash Kumar <[email protected]>

Update solutions/security-enforced/variables.tf

1bec048

Co-authored-by: Akash Kumar <[email protected]>

Update solutions/quickstart/catalogValidationValues.json.template

59b290a

Co-authored-by: Akash Kumar <[email protected]>

Update solutions/quickstart/variables.tf

eef1eb0

Co-authored-by: Akash Kumar <[email protected]>

Update solutions/quickstart/variables.tf

11546e3

Co-authored-by: Akash Kumar <[email protected]>

ocofaigh requested changes Jun 11, 2025

View reviewed changes

resolve review comments

8f90a56

updated PR for improving User experience

633d240

feat : Added Event Streams DA (Standard and Security-Enforced Variation) #397

Are you sure you want to change the base?

feat : Added Event Streams DA (Standard and Security-Enforced Variation) #397

Conversation

Khuzaima05 commented May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Release required?

Release notes content

Run the pipeline

Checklist for reviewers

For mergers

Uh oh!

Khuzaima05 commented May 14, 2025

Uh oh!

Khuzaima05 commented May 14, 2025

Uh oh!

Khuzaima05 commented May 14, 2025

Uh oh!

Khuzaima05 commented May 14, 2025

Uh oh!

Khuzaima05 commented May 14, 2025

Uh oh!

Khuzaima05 commented May 14, 2025

Uh oh!

Khuzaima05 commented May 14, 2025

Uh oh!

Khuzaima05 commented May 14, 2025

Uh oh!

Khuzaima05 commented May 22, 2025

Uh oh!

ocofaigh commented May 26, 2025

Uh oh!

ocofaigh commented May 27, 2025

Uh oh!

Khuzaima05 commented May 29, 2025

Uh oh!

Ak-sky left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ocofaigh left a comment

Choose a reason for hiding this comment

Uh oh!

Khuzaima05 commented Jun 12, 2025

Uh oh!

Khuzaima05 commented Jun 12, 2025

Uh oh!

Khuzaima05 commented Jun 12, 2025

Uh oh!

Khuzaima05 commented Jun 12, 2025

Uh oh!

Uh oh!

Khuzaima05 commented May 5, 2025 •

edited

Loading

Ak-sky left a comment •

edited

Loading