Check if country is US and add state to request #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netbanx gives a parse error if the state value is blank or not US
This reverts commit 6864c49.
If Country is US then we include the state in the request. Otherwise ignore for international. This stops the parse error received from netbanx.
|
Should be good now mate :) |
|
Would be good to add some tests for this too. You can just copy the layout in this or other omnipay gateways (or if you can't figure it out, I'll add them and merge this when I get time) |
|
Hi this is still a problem for non US payments |
|
@shaunpreston Can you add in some tests for the change, and I'll happily merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.