Skip to content

Support Vite 6 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Support Vite 6 #13

merged 3 commits into from
Jan 23, 2025

Conversation

colecrouter
Copy link
Contributor

Apologies in advance, I was not able to find the exact version/change/package that led to this issue, nor could I find out exactly what the issue entails.

When trying to upgrade to Vite 6 (and supported Svelte & SvelteKit versions), there are a couple compiler warnings. As well, any tests using Vitest + @testing-library/svelte fail to import this library:

Error: Failed to resolve entry for package "@thisux/sveltednd". The package may have incorrect main/module/exports specified in its package.json: No known conditions for "." specifier in "@thisux/sveltednd" package

I suspect this has something to do with Vite 6's new module resolution system.

I was able to fix this by slightly modifying package.json. I also updated this package/site to Vite 6 + bumped the appropriate deps.

colecrouter and others added 3 commits January 4, 2025 16:51
Removed redundant "types" export, added "import" and "require" to help Vite 6's new module resolution.
Importing vitePreprocess for TypeScript is unnecessary since Svelte 5.
@Spikeysanju Spikeysanju self-assigned this Jan 23, 2025
@Spikeysanju Spikeysanju requested a review from Copilot January 23, 2025 05:16
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • package.json: Language not supported

@Spikeysanju
Copy link
Contributor

This pull request includes updates to dependencies and configuration files for a Svelte project. The most important changes involve updating package versions and modifying the svelte.config.js file.

Dependency updates:

  • package.json: Updated @sveltejs/adapter-cloudflare to version ^5.0.0, @sveltejs/kit to version ^2.15.1, svelte to version ^5.16.1, and vite to version ^6.0.7. Added "import" and "require" fields to the exports section. [1] [2]

Configuration changes:

@Spikeysanju Spikeysanju merged commit 8fa0da8 into thisuxhq:main Jan 23, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants