Development test git #474
Merged
Development test git #474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhost39
requested review from
abom,
AhmedHanafy725,
m-motawea,
rkhamis,
waleedhammam and
xmonader
as code owners
AhmedHanafy725
requested changes
Oct 15, 2020
There was a problem hiding this comment.
- Please install pre-commit https://github.com/threefoldtech/js-ng/blob/development/docs/wiki/contribution.md#pre-commit
Scenarios need to be covered.
- Setting a remote url and check that the git config has been changed to the new url, and also from the property (remote_url).
- Commit changes with
add_all=False.
Codecov Report
@@ Coverage Diff @@
## development #474 +/- ##
===============================================
+ Coverage 68.31% 68.71% +0.39%
===============================================
Files 83 85 +2
Lines 3895 3941 +46
===============================================
+ Hits 2661 2708 +47
+ Misses 1234 1233 -1
Continue to review full report at Codecov.
|
…into development
AhmedHanafy725
requested changes
Oct 21, 2020
AhmedHanafy725
requested changes
Oct 27, 2020
abom
reviewed
Oct 29, 2020
| @@ -15,5 +16,8 @@ def tearDown(self): | |||
| def generate_random_text(): | |||
| return j.data.idgenerator.chars(10) | |||
|
|
|||
| def random_name(self): | |||
| return j.data.idgenerator.nfromchoices(10, string.ascii_letters) | |||
There was a problem hiding this comment.
Can be replaced by
Suggested change
| return j.data.idgenerator.nfromchoices(10, string.ascii_letters) | |
| return j.data.idgenerator.chars(10) |
There was a problem hiding this comment.
some names invalid like name start with number
AhmedHanafy725
requested changes
Nov 16, 2020
AhmedHanafy725
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test coverage for Git client
Related Issues
#472